Closed
Conversation
nodejs-github-bot
added
the
meta
BridgeAR
approved these changes
May 10, 2018
| Yichao 'Peak' Ji <peakji@users.noreply.github.com> | ||
| Jesse W. Collins <jesse.w.collins@gmail.com> | ||
| TSUYUSATO Kitsune <make.just.on@gmail.com> | ||
| daGo <daniel1kdago@gmail.com> |
devsnek
approved these changes
May 10, 2018
cjihrig
approved these changes
May 10, 2018
danbev
approved these changes
May 11, 2018
trivikr
approved these changes
May 11, 2018
addaleax
removed
the
fast-track
jasnell
approved these changes
May 12, 2018
targos
added a commit
to targos/node
that referenced
this pull request
May 13, 2018
PR-URL: nodejs#20658 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in 6de0f55 |
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
PR-URL: #20658 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.