tools: hide symbols for builtin JS files in binary#20634
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
tools: hide symbols for builtin JS files in binary#20634addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Do not expose symbols like `node::internal_process_next_tick_value`, `node::internal_process_next_tick_key` in the created `node` binary by wrapping them in an anonymous namespace.
nodejs-github-bot
added
the
build
Member
Author
jasnell
approved these changes
May 9, 2018
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM. Is this technically semver-major?
Member
Author
This change is completely internals-only, and at least on my local build these symbols aren’t even external symbols. This is really a pretty minor change here. :) |
devsnek
approved these changes
May 9, 2018
cjihrig
approved these changes
May 9, 2018
bnoordhuis
approved these changes
May 9, 2018
tniessen
approved these changes
May 9, 2018
danbev
approved these changes
May 11, 2018
Member
Author
|
Windows CI re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/17899/ |
addaleax
added
the
author ready
TimothyGu
approved these changes
May 11, 2018
Member
Author
|
Landed in 7b39503 |
addaleax
added a commit
that referenced
this pull request
May 14, 2018
Do not expose symbols like `node::internal_process_next_tick_value`, `node::internal_process_next_tick_key` in the created `node` binary by wrapping them in an anonymous namespace. PR-URL: #20634 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
addaleax
added a commit
that referenced
this pull request
May 14, 2018
Do not expose symbols like `node::internal_process_next_tick_value`, `node::internal_process_next_tick_key` in the created `node` binary by wrapping them in an anonymous namespace. PR-URL: #20634 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not expose symbols like
node::internal_process_next_tick_value,node::internal_process_next_tick_keyin the creatednodebinaryby wrapping them in an anonymous namespace.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes