stream: no need to initial er with false#20607
Closed
JacksonTian wants to merge 1 commit intonodejs:masterfrom
Closed
stream: no need to initial er with false#20607JacksonTian wants to merge 1 commit intonodejs:masterfrom
JacksonTian wants to merge 1 commit intonodejs:masterfrom
Conversation
initial `er` with false is unnecessarily.
nodejs-github-bot
added
the
stream
lpinca
approved these changes
May 8, 2018
cjihrig
approved these changes
May 9, 2018
starkwang
approved these changes
May 9, 2018
Contributor
jasnell
approved these changes
May 9, 2018
lpinca
added
the
author ready
2 tasks
trivikr
approved these changes
May 13, 2018
Member
|
Landed in 0e9ea35 |
trivikr
pushed a commit
that referenced
this pull request
May 13, 2018
initial `er` with false is unnecessarily. PR-URL: #20607 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
initial `er` with false is unnecessarily. PR-URL: #20607 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial
erwith false is unnecessarily.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes