fs: use _final() for fs.WriteStream#20562
Closed
JacksonTian wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
use _final() method instead of once 'finish' event.
nodejs-github-bot
added
the
fs
lpinca
approved these changes
May 6, 2018
Member
lpinca
added
the
author ready
trivikr
approved these changes
May 13, 2018
jasnell
approved these changes
May 14, 2018
Member
|
Landed in 3746187 |
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
use _final() method instead of once 'finish' event. PR-URL: #20562 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
use _final() method instead of once 'finish' event. PR-URL: #20562 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use _final() method instead of once 'finish' event.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes