Closed
Conversation
Rename test-fs-chdir-errormessage.js to test-process.chdir-errormessage.js. The test is for process.chdir(). There is no fs.chdir().
Member
Author
|
👍 this comment if you approve fast-tracking this. |
Member
Author
vsemozhetbyt
approved these changes
May 5, 2018
vsemozhetbyt
added
the
author ready
cjihrig
approved these changes
May 5, 2018
trivikr
approved these changes
May 5, 2018
Member
|
Landed in 2fda625 |
addaleax
pushed a commit
that referenced
this pull request
May 5, 2018
Rename test-fs-chdir-errormessage.js to test-process.chdir-errormessage.js. The test is for process.chdir(). There is no fs.chdir(). PR-URL: #20532 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Rename test-fs-chdir-errormessage.js to test-process.chdir-errormessage.js. The test is for process.chdir(). There is no fs.chdir(). PR-URL: #20532 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Rename test-fs-chdir-errormessage.js to test-process.chdir-errormessage.js. The test is for process.chdir(). There is no fs.chdir(). PR-URL: #20532 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
Rename test-fs-chdir-errormessage.js to test-process.chdir-errormessage.js. The test is for process.chdir(). There is no fs.chdir(). PR-URL: #20532 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename test-fs-chdir-errormessage.js to
test-process.chdir-errormessage.js. The test is for process.chdir().
There is no fs.chdir().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes