tools: ignore VS compiler output under deps/v8/gypfiles#20527
Closed
fs-eire wants to merge 1 commit intonodejs:masterfrom
fs-eire:ignore-vs-compiler-output-under-deps-v8-gypfiles
Closed
tools: ignore VS compiler output under deps/v8/gypfiles#20527fs-eire wants to merge 1 commit intonodejs:masterfrom fs-eire:ignore-vs-compiler-output-under-deps-v8-gypfiles
fs-eire wants to merge 1 commit intonodejs:masterfrom
fs-eire:ignore-vs-compiler-output-under-deps-v8-gypfiles
Conversation
nodejs-github-bot
added
the
meta
fs-eire
changed the title
targos
approved these changes
May 4, 2018
cjihrig
approved these changes
May 5, 2018
BridgeAR
approved these changes
May 5, 2018
BridgeAR
added
the
author ready
Member
|
The commit message has to be fixed to e.g., |
jasnell
approved these changes
May 6, 2018
fs-eire
changed the title
trivikr
approved these changes
May 8, 2018
targos
pushed a commit
that referenced
this pull request
May 10, 2018
Add gitignore rules to ignore compiler output under deps/v8/gypfiles. PR-URL: #20527 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
targos
pushed a commit
that referenced
this pull request
May 12, 2018
Add gitignore rules to ignore compiler output under deps/v8/gypfiles. PR-URL: #20527 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes