doc: add trace category for fs sync methods#20526
Closed
chinhuang007 wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add trace category for fs sync methods#20526chinhuang007 wants to merge 1 commit intonodejs:masterfrom
chinhuang007 wants to merge 1 commit intonodejs:masterfrom
Conversation
Add the trace category for file system synchronous methods to documentation so the users can enable it when they want to look into file system sync method trace data. Refs: nodejs#19649
vsemozhetbyt
added
the
trace_events
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
vsemozhetbyt
added
the
fast-track
Contributor
|
cc @nodejs/trace-events |
jasnell
approved these changes
May 4, 2018
vsemozhetbyt
added
the
author ready
ofrobots
approved these changes
May 4, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM. Additions of trace event macros to sync fs methods to come later?
trivikr
approved these changes
May 5, 2018
BridgeAR
approved these changes
May 5, 2018
cjihrig
approved these changes
May 5, 2018
Contributor
|
Landed in 852c459 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
May 8, 2018
Add the trace category for file system synchronous methods to documentation so the users can enable it when they want to look into file system sync method trace data. PR-URL: #20526 Refs: #19649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Add the trace category for file system synchronous methods to documentation so the users can enable it when they want to look into file system sync method trace data. PR-URL: #20526 Refs: #19649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Add the trace category for file system synchronous methods to documentation so the users can enable it when they want to look into file system sync method trace data. PR-URL: #20526 Refs: #19649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
Add the trace category for file system synchronous methods to documentation so the users can enable it when they want to look into file system sync method trace data. PR-URL: #20526 Refs: #19649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the trace category for file system synchronous methods to
documentation so the users can enable it when they want to look
into file system sync method trace data.
Refs: #19649
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes