test: remove crypto.DEFAULT_ENCODING usage#20221
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove crypto.DEFAULT_ENCODING usage#20221danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
This commit removes the usage of the deprectated crypto.DEFAULT_ENCODING.
Contributor
Author
BridgeAR
approved these changes
Apr 23, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Apr 23, 2018
trivikr
approved these changes
Apr 24, 2018
Contributor
Author
|
Landed in c521a20. |
danbev
added a commit
to danbev/node
that referenced
this pull request
Apr 25, 2018
This commit removes the usage of the deprectated crypto.DEFAULT_ENCODING. PR-URL: nodejs#20221 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Contributor
|
Should this be backported to |
tniessen
pushed a commit
to tniessen/node
that referenced
this pull request
May 13, 2018
This commit removes the usage of the deprectated crypto.DEFAULT_ENCODING. PR-URL: nodejs#20221 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the usage of the deprectated
crypto.DEFAULT_ENCODING.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes