module: fix stat with long paths on windows#2011
Closed
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Closed
module: fix stat with long paths on windows#2011Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Fishrock123 wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
LGTM but a regression test would be nice. |
Member
|
this test I added in #1991 may be enough. I can try when I am back home. |
Member
|
or start a CI on master ? It will fail if I am right |
Member
|
I still think that it might be better to wrap |
Contributor
Author
Member
|
@ChALkeR I agree. We can introduce |
Contributor
Author
|
CI on master does not appear to catch it? |
Member
|
apparently not 😞 |
Contributor
+1 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/nodejs/io.js/pull/1920/files#r32701699, this also requires the long path fix from #1991