test: remove expectations based on v8 headers from types test#20003
Closed
devsnek wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove expectations based on v8 headers from types test#20003devsnek wants to merge 1 commit intonodejs:masterfrom
devsnek wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Author
Member
|
I see the point of removing this but it is a nice check nevertheless. Is there any place that we can move this part to, to make sure we run it when updating V8? That way we would not miss it. |
Member
|
If nothing else, the way it scans v8.h is kinda fragile. A doc comment with |
Member
Author
|
still looking for some approvals... |
jasnell
approved these changes
Apr 13, 2018
cjihrig
approved these changes
Apr 13, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. I don't really see the need for a fast track though.
Member
Author
|
@cjihrig it was blocking the ci but we fixed it in the v8 fork of node to be overwritten at some point i guess. this should still land but i'll remove the fast track |
devsnek
removed
the
fast-track
trivikr
approved these changes
Apr 14, 2018
devsnek
added a commit
that referenced
this pull request
Apr 15, 2018
PR-URL: #20003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
Author
|
landed in 73f13ba |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #20003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#20003 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @addaleax
if v8 adds any new type checks this breaks their CI until node updates, so i think its just safer to just remove this check
check out https://logs.chromium.org/v/?s=v8%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8949374903458528112%2F%2B%2Fsteps%2Fbuild_addons_and_test_node.js%2F0%2Fstdout
blocking https://chromium-review.googlesource.com/c/v8/v8/+/1011762
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes