zlib,stream: use “official” util.types typechecks#19602
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
zlib,stream: use “official” util.types typechecks#19602addaleax wants to merge 1 commit intonodejs:masterfrom
util.types typechecks#19602addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
The old variants have been deprecated since b20af80. Refs: nodejs#18415
nodejs-github-bot
added
stream
TimothyGu
approved these changes
Mar 26, 2018
starkwang
approved these changes
Mar 26, 2018
cjihrig
approved these changes
Mar 26, 2018
Member
Author
joyeecheung
approved these changes
Mar 26, 2018
lpinca
approved these changes
Mar 26, 2018
lpinca
added
the
author ready
jasnell
approved these changes
Mar 28, 2018
Member
|
Landed in e765257 |
trivikr
pushed a commit
that referenced
this pull request
Mar 28, 2018
The old variants have been deprecated since b20af80. Refs: #18415 PR-URL: #19602 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
removed
the
author ready
Member
|
Depends on #18415 to land on |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
The old variants have been deprecated since b20af80. Refs: nodejs#18415 PR-URL: nodejs#19602 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old variants have been deprecated since b20af80.
Refs: #18415
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes