tools: fix nits in tools/doc/common.js#19599
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:tools-doc-common
Closed
tools: fix nits in tools/doc/common.js#19599vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:tools-doc-common
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:tools-doc-common
Conversation
vsemozhetbyt
added
the
fast-track
nodejs-github-bot
added
doc
addaleax
approved these changes
Mar 25, 2018
Contributor
Author
|
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/333/ Let me know if we need full CI for this. |
lpinca
approved these changes
Mar 25, 2018
vsemozhetbyt
added
the
author ready
vsemozhetbyt
added a commit
that referenced
this pull request
Mar 25, 2018
PR-URL: #19599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
Author
|
Landed in 50e5eff |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
PR-URL: #19599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
PR-URL: #19599 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes.match()with.test()in a boolean context.