build: simplify execution of built binary#1955
Closed
jbergstroem wants to merge 1 commit intonodejs:masterfrom
Closed
build: simplify execution of built binary#1955jbergstroem wants to merge 1 commit intonodejs:masterfrom
jbergstroem wants to merge 1 commit intonodejs:masterfrom
Conversation
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=)
Member
There was a problem hiding this comment.
perhaps this should also go down in to test-npm.sh? / @Fishrock123
Contributor
There was a problem hiding this comment.
Yes, I unrelatedly figured out that this was broken after quickly discussing it at nodeconf. I'll open a PR.
Contributor
|
The usage of both NODE and NODE_EXE throughout the makefile is slightly confusing.
|
Member
Author
|
@orangemocha I'm all for making it more readable. I'd prefer to do it in another PR so we can land this and get a linter jenkins slave up and running. |
Member
Author
|
Ping @nodejs/build or other collaborators. I'd like to land this so we can get the linter going. |
Member
|
LGTM |
Member
Author
|
Here's a run through the new linter project: https://jenkins-iojs.nodesource.com/job/iojs+linter/3/ |
Member
|
lgtm, :makeitso: |
jbergstroem
added a commit
that referenced
this pull request
Jun 15, 2015
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: #1955 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
Member
Author
|
Merged in 1ec53c0. Thanks for the review. Proceeding to setting the linter job up! |
rvagg
pushed a commit
to rvagg/io.js
that referenced
this pull request
Jul 3, 2015
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: nodejs#1955 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
jbergstroem
added a commit
that referenced
this pull request
Jul 3, 2015
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: #1955 PORT-PR-URL: #2101 PORT-FROM: 1ec53c0 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
This was referenced Jun 22, 2023
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=).
R=@nodejs/build