test: replace third argument in assert.strictEqual

[ryzokuken]

Replace the third argument in assert.strictEqual with something much
more informative so that it display relevant information when the
test fails

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test

[ryzokuken]

@Trott here it is! 😄

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/13523/

[apapirovski]

This would be better with no message at all which will then show a comparison of the two values.

[apapirovski]

But if we do put a message in, it should be similar to the one above it and mention at what index the error occurred and for what hash. At least that's information that's not provided by the default strictEqual message.

[ryzokuken]

@apapirovski is it better now? Let me know if anything is amiss.

[apapirovski]

Lite CI for the change: https://ci.nodejs.org/job/node-test-pull-request-lite/224/

[lpinca]

LGTM but I agree with @apapirovski. Almost all strictEqual assertions are better without the message argument.

[ryzokuken]

@lpinca @apapirovski so, should I remove it altogether? As it is, it does give us some extra information (hash and index)

[BridgeAR]

In this case it is probably fine to have the extra message. Otherwise it is difficult to see what test case just ran.

[apapirovski]

I'm fine with it either way. It offers a bit more info since it provides the hash and index, which would make debugging a tiny bit easier. Admittedly that can also be gleaned from the comparison value but it's a bit less convenient.

[jasnell]

Landed in 78a7536