Skip to content

[v9.x backport] trace_events: add file pattern cli option#19144

Closed
AndreasMadsen wants to merge 1 commit intonodejs:v9.x-stagingfrom
AndreasMadsen:backport-18480-to-v9.x
Closed

[v9.x backport] trace_events: add file pattern cli option#19144
AndreasMadsen wants to merge 1 commit intonodejs:v9.x-stagingfrom
AndreasMadsen:backport-18480-to-v9.x

Conversation

@AndreasMadsen
Copy link
Member

@AndreasMadsen AndreasMadsen commented Mar 5, 2018

Allow the user to specify the filepath for the trace_events log file
using a template string.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

trace_events

@AndreasMadsen
trace_events: add file pattern cli option
8d6d608 
Allow the user to specify the filepath for the trace_events log file
using a template string.

PR-URL: #18480
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v9.x labels Mar 5, 2018
@AndreasMadsen AndreasMadsen changed the title [v6.x backport] trace_events: add file pattern cli option [v9.x backport] trace_events: add file pattern cli option Mar 5, 2018
@AndreasMadsen AndreasMadsen added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Mar 5, 2018
@AndreasMadsen
Copy link
Member Author

AndreasMadsen commented Mar 5, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13498/

@AndreasMadsen AndreasMadsen added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 5, 2018
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 6, 2018 •
edited
Loading

landed in 3d4cda3

@MylesBorins MylesBorins closed this Mar 6, 2018
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@AndreasMadsen @MylesBorins
trace_events: add file pattern cli option
3d4cda3 
Allow the user to specify the filepath for the trace_events log file
using a template string.

Backport-PR-URL: #19144
PR-URL: #18480
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndreasMadsen @MylesBorins @nodejs-github-bot