[v8.x backport] doc: add new documentation rule#19065
Closed
estrada9166 wants to merge 1 commit intonodejs:v8.x-stagingfrom
estrada9166:backporting-v8x-staging
Closed
[v8.x backport] doc: add new documentation rule#19065estrada9166 wants to merge 1 commit intonodejs:v8.x-stagingfrom estrada9166:backporting-v8x-staging
estrada9166 wants to merge 1 commit intonodejs:v8.x-stagingfrom
estrada9166:backporting-v8x-staging
Conversation
nodejs-github-bot
added
build
Backporting doc changes. Refs: #18981 Refs: #18726 (comment)
Member
Contributor
|
@estrada9166 this has not yet landed on v9.x, we won't be able to land on v8.x until it has landed also can you please retain all the original meta data of the initial commit including the sign off data |
Contributor
Author
|
@MylesBorins I'm waiting some opinions on this PR (It'll check that all the dependencies related to Thank you so much for your comments! |
MylesBorins
force-pushed
the
v8.x-staging
branch
2 times, most recently
from
44cb0d3 to
16bf5fe
Compare
MylesBorins
force-pushed
the
v8.x-staging
branch
2 times, most recently
from
5ac4bac to
591812f
Compare
MylesBorins
force-pushed
the
v8.x-staging
branch
from
084ef60 to
859dc64
Compare
Contributor
|
I'm closing this. We can reopen or make a new PR when upstream change lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting doc changes.
Refs: #18981
Refs: #18726 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc