test : refactor parallel/test-tls-async-cb-after-socket-end#18985
test : refactor parallel/test-tls-async-cb-after-socket-end#18985juggernaut451 wants to merge 1 commit intonodejs:masterfrom
Conversation
There was a problem hiding this comment.
Since the callback is empty it can be omitted from common.mustCall().
There was a problem hiding this comment.
I meant that this could be just common.mustCall().
There was a problem hiding this comment.
sorry wrong interpreted
There was a problem hiding this comment.
change made :)
There was a problem hiding this comment.
fixed :) Thanks for pointing out
There was a problem hiding this comment.
Nit: it would be great to remove this line again.
davisokoth
left a comment
davisokoth
left a comment
There was a problem hiding this comment.
Code looks good. Kindly consider squashing this into one commit (https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-squashing)
|
LGTM with @davisokoth 's comment about squashing. |
juggernaut451
force-pushed
the
refactorTestTlsAsyncCbAfterSocketEnd
branch
from
c4ce57a to
855826f
Compare
|
change made :) |
|
CI is failing for |
|
node-test-commit-linux was rerun, failed again for |
|
Landed in d1156da |
PR-URL: nodejs#18985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #18985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 participants
this replaces the function with arrow function, callback by common.mustCall
and added the description
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test