doc: mention git-node in the collaborator guide#18960
doc: mention git-node in the collaborator guide#18960joyeecheung wants to merge 2 commits intonodejs:masterfrom
Conversation
joyeecheung
force-pushed
the
git-node-guide
branch
from
2ae68e9 to
ffe0c38
Compare
COLLABORATOR_GUIDE.md
Outdated
| $ git node land $PRID | ||
| ``` | ||
|
|
||
| If it's the first time you have ever use `node-core-utils`, you will be prompted |
COLLABORATOR_GUIDE.md
Outdated
| <a name="metadata"></a> | ||
| * Modify the original commit message to include additional metadata regarding | ||
| the change process. ([`node-core-utils`][] fetches the metadata for you.) | ||
| the change process. (the [`git node metadata`][git-node-metadata] command |
There was a problem hiding this comment.
Nit: . (the -> . (The?
vsemozhetbyt
added
the
meta
joyeecheung
added
the
author ready
|
Going to attempts to land this as my first PR with git-node :) |
|
So, I actually discovered something wrong with this PR while trying to land it :D the instructions won't work since all collaborators are required to turn on 2FA nowadays - so the instructions here need to be updated to use the access-token method (rather than the password prompt) as that won't work. |
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Will gladly approve again once the guide is updated for 2FA GitHub
|
@benjamingr I don't think 2FA has much to do with this? ghauth should ask you for the OTP as well if you use the tool to generate the token. |
|
BTW this is how it looks if you have 2FA in your account |
I have 2FA turned on, this was my correct password, and I did not get a 2FA prompt. For what it's worth I use SSH normally (rather than https) (I'm aware I can fix this by setting the token in the instructions, but I'm interested in making sure new collaborators are successful in using the tool based on the guide and this PR (The tool is really useful)) |
|
@benjamingr I think that means you have typed your password wrong..? |
I've just tried from another computer and I think it's my (messy) terminal at fault, going to attempt to land again. |
|
Landed in 1bb92ce Awesome tool @joyeecheung :) |
PR-URL: #18960 Fixes: #18197 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: nodejs#18960 Fixes: nodejs#18197 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: #18960 Fixes: #18197 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: nodejs#18960 Fixes: nodejs#18197 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
|
There's no need to backport this to 8.x or 6.x |
10 participants
Fixes: #18197
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc