Conversation
Revert "dgram: call send callback asynchronously" partially, since the fix is now done in libuv. Refs: nodejs#1313 Refs: libuv/libuv#371
|
While the convergence process takes place, should I also PR joyent/node ? |
|
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/762/
|
|
I'd like to run the CI again since #1881 landed. That commit should fix most of the red, and I want to see if the other two failures were flakey. CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/764/ |
|
Looks like |
Fixes: nodejs/node-v0.x-archive#9310 PR-URL: #1889 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Revert "dgram: call send callback asynchronously" partially, since the fix is now done in libuv. Refs: #1313 Refs: libuv/libuv#371 PR-URL: #1889 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Cheers Saúl, landed in a804026...b5cd2f0. |
|
@saghul || @bnoordhuis can either of you provide us with a line or two to put in the changelog for this upgrade? |
|
Seems to cause one new failure on centos5-32/64: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/764/nodes=centos5-32/tapTestReport/test.tap-500/ Edit: same test fails in the same build for smartos32/64 too. I haven't seen this test fail previously (perhaps missed it). |
|
@jbergstroem the test is new. Looks like it landed in #1855 less than 24 hours ago. |
|
@cjihrig hm. I'll try backing out the libuv upgrade to see if it still fails. |
|
@cjihrig yep, can't reproduce reliably. |
|
@cjihrig @jbergstroem The CI was run (sorry) on #1881. The test should only fail on branches based on bd99e8d...a804026. Rebasing the branch onto |
|
@rvagg the 2 things that directly affect iojs would be:
|
|
@saghul Thank you for nodejs/node-v0.x-archive#25475, it is very much appreciated! |
Notable Changes: * libuv: Upgraded to 1.6.0 and 1.6.1, see full ChangeLog for details. (Saúl Ibarra Corretgé) #1905 #1889. Highlights include: - Fix TTY becoming blocked on OS X - Fix UDP send callbacks to not to be synchronous - Add uv_os_homedir() (exposed as os.homedir(), see below) * npm: See full release notes for details. (Kat Marchán) #1899. Highlight: - Use GIT_SSH_COMMAND (available as of Git 2.3) * openssl: - Upgrade to 1.0.2b and 1.0.2c, introduces DHE man-in-the-middle protection (Logjam) and fixes malformed ECParameters causing infinite loop (CVE-2015-1788). See the security advisory for full details. (Shigeki Ohtsu) #1950 #1958 - Support FIPS mode of OpenSSL, see README for instructions. (Fedor Indutny) #1890 * os: Add os.homedir() method. (Colin Ihrig) #1791 * smalloc: Deprecate whole module. (Vladimir Kurchatkin) #1822 * Add new collaborators: - Alex Kocharin (@rlidwka) - Christopher Monsanto (@monsanto) - Ali Ijaz Sheikh (@ofrobots) - Oleg Elifantiev (@Olegas) - Domenic Denicola (@domenic) - Rich Trott (@Trott)
7 participants
R=@bnoordhuis