build: no longer have v8-debug.h as dependency.#18677
Closed
hashseed wants to merge 1 commit intonodejs:masterfrom
Closed
build: no longer have v8-debug.h as dependency.#18677hashseed wants to merge 1 commit intonodejs:masterfrom
hashseed wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
bnoordhuis
approved these changes
Feb 9, 2018
cjihrig
approved these changes
Feb 9, 2018
BridgeAR
approved these changes
Feb 9, 2018
BridgeAR
added
fast-track
Member
jasnell
approved these changes
Feb 9, 2018
tniessen
approved these changes
Feb 10, 2018
Member
|
Landed in 4a1a4bf 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 10, 2018
Ref: nodejs#18643 PR-URL: nodejs#18677 Refs: nodejs#18643 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Ref: nodejs#18643 PR-URL: nodejs#18677 Refs: nodejs#18643 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer necessary, and V8 is planning to remove the file altogether.
Ref: #18643
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build