[backport-v8.x] backport npm/npm@4ca6958

[kasicka]

Backporting npm/npm@4ca6958 ( 9f33a24 and b8888f5) that wasn't backported in #16509

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[richardlau]

cc @nodejs/lts

IMO we should include this in #18336. Because we floated these patches on master/v9.x they were missing from the subsequent upgrade npm to 5.6.0 PR #17535 / #17777 so when they were backported without these patches we ended up with files that don't match the equivalent in https://github.com/npm/npm/blob/v5.6.0.

[gibfahn]

Why do we need to include the v9.x compatibility patch?

EDIT: Just read #16509 (comment), fair enough I guess.

[MylesBorins]

So I'm leaning towards us simply relanding 5.6.0 following the instructions at https://github.com/nodejs/node/blob/master/doc/guides/maintaining-npm.md

Thoughts

[MylesBorins]

I've opened #18625 as an alternative. In it I completely relanded 5.6.0 following our maintaining npm guide

[MylesBorins]

I'd like to land #18625 instead as it seems less error prone

@kasicka thank you for opening this PR

[gibfahn]

So I'm leaning towards us simply relanding 5.6.0 following the instructions at /doc/guides/maintaining-npm.md@master

Thoughts

Sounds like a good idea to me.

[gibfahn]

Landed #18625, @kasicka thanks a lot for raising the PR and for telling us about the bug. Please take a look at the v8.x-staging branch (or the next RC) and make sure it fixes the issue you were seeing.