doc: fix typo in http2.md#18602
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-http2-typo
Closed
doc: fix typo in http2.md#18602vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:doc-http2-typo
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-http2-typo
Conversation
vsemozhetbyt
added
the
fast-track
nodejs-github-bot
added
doc
Contributor
Author
apapirovski
approved these changes
Feb 6, 2018
lpinca
approved these changes
Feb 6, 2018
Contributor
Author
|
Do I understand correctly that CI failure is unrelated? Should we wait till "all green"? |
3 tasks
Contributor
|
FWIW I'm reasonably certain this can land without the linuxone run (but maybe not the other PR before it). It's correcting a doc spelling error, which means it's impossible for it to affect the regular CI. |
Contributor
Author
|
@apapirovski Well, linuxone includes doc building tests, so I always try to reassure myself. But this fix just makes this fragment similar to some others, so maybe we can go on) |
Contributor
Author
|
Landed in d1d9e2f |
vsemozhetbyt
added a commit
that referenced
this pull request
Feb 6, 2018
PR-URL: #18602 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18602 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18602 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18602 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#18602 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18602 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Mar 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, http2