test: add useful info to error msg and refactor

[chinhuang007]

Add useful info about process.domain to error meesages in the
uncaughtException event listener and the beforeExit event listener.

Refactor code such as using template literals, and also make sure
uncaughtException listner is detached after firing once to avoid
endless loop in case of exception throw in the beforeExit event
listner.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test

[lpinca]

This will print the message on two lines and add 4 spaces at the beginning of the second one. I think it's better to use a single line.

[Trott]

If a single line of code exceeds 80 chars, you can keep it as a single line of output like this:

'Domains stack should be empty in uncaughtException handler' +
`but the value of process.domain is ${JSON.stringify(process.domain)}`);

[Trott]

Alternatively, you can simply remove the message (3rd) argument entirely and the default behavior will print the value of process.domain. If you think the contents of the message are valuable, you can put them as a comment right above the call to assert.strictEqual().

[chinhuang007]

Thanks, @lpinca @Trott, for the comments. The message is on one line now.

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/12976/

[chinhuang007]

The CI failure yesterday doesn't seem related to my change. Just rebased. Can someone start a new CI please?

[BridgeAR]

@chinhuang007 don't worry about those. Our CI often either has some infrastructure failures and or test flakes.

[BridgeAR]

Landed in c3ff899 🎉

@chinhuang007 congratulations on your first commit to Node.js!