Closed
Conversation
apapirovski
added
test
nodejs-github-bot
added
test
Contributor
Author
Member
|
@apapirovski the benchmark itself got fixed by f951c9a. But the test would be great nevertheless! Would you please rebase? :-) |
BridgeAR
reviewed
Feb 1, 2018
Member
There was a problem hiding this comment.
This seems unrelated to the tls test?
Contributor
Author
There was a problem hiding this comment.
Updated and rebased.
apapirovski
force-pushed
the
fix-benchmark-tls-connect
branch
from
c6d5a2f to
d6580f2
Compare
apapirovski
changed the title
apapirovski
changed the title
BridgeAR
approved these changes
Feb 1, 2018
BridgeAR
added
the
author ready
Member
apapirovski
removed
the
benchmark
Contributor
Author
|
One of the benchmarks was a bit flaky so I've committed an adjustment that should make it reliably pass in tests. |
jasnell
approved these changes
Feb 2, 2018
Contributor
Author
|
Landed in 5c2c412 |
apapirovski
added a commit
that referenced
this pull request
Feb 4, 2018
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change to benchmarks broke one of the TLS benchmarks and since we have no tests for these it went undetected. This
fixes the issue and alsointroduces a test for TLS benchmarks.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark, test