build: include the libuv and zlib into node

[yhwang]

Add libuv and zlib into node executable and shared lib. Also fix an
issue that openssl is not fully included in node executable for macOS.

fixes #17444

Signed-off-by: Yihong Wang [email protected]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

build

[addaleax]

LGTM if CI is happy:

CI: https://ci.nodejs.org/job/node-test-commit/15690/

[yhwang]

This test case failed on Windows: parallel/test-tls-server-verify. I saw someone is fixing it now. Not related to my change.

[bnoordhuis]

ldflags applies only to platforms that aren't Windows or MacOS so this is better written as OS != "aix", which I think the intent was? Likewise on line 165.

[yhwang]

yes and changed.

[bnoordhuis]

Can you indent here? It's a line (and string) continuation.

[yhwang]

good catch and done

[yhwang]

updated the change based on @bnoordhuis comments

[bnoordhuis]

Thanks, LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/12804/

[yhwang]

Looks like the error of AIX shows up in other PR. is the AIX env for CI broken?

[bnoordhuis]

Infrastructure issue. Let's try it one more time for good luck: https://ci.nodejs.org/job/node-test-commit/15775/

There's also this but I can't say if it's caused by this PR:

Building addon /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/addons-napi/test_make_callback/
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp info chdir /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/addons/heap-profiler/
Aborted
Makefile:326: recipe for target 'test/addons/.buildstamp' failed
make[1]: *** [test/addons/.buildstamp] Error 1

[bnoordhuis]

Not a happy run either... the alpine buildbot failure is most likely a flaky test but I don't immediately see why the linuxone run failed and the aix buildbot still has infrastructure issues.

cc @nodejs/build - known issue?

[yhwang]

the weird thing is I can't tell the root cause from the console log (the linuxone)

[mhdawson]

LGTM

[mhdawson]

Another CI run: https://ci.nodejs.org/job/node-test-pull-request/12853/

[mhdawson]

This is another CI run, https://ci.nodejs.org/job/node-test-commit/15831/

[mhdawson]

In the last CI run there were failures on debian, but this unrelated PR has the excact same failures: https://ci.nodejs.org/job/node-test-commit-linux/15991/nodes=debian8-64/console. That and the fact that some earlier CI runs for this PR did not have failures on debian mean that I believe the CI run is good.

[BridgeAR]

@yhwang would you be so kind and rebase? :-)

[yhwang]

@BridgeAR thanks for the reminding. rebase is done. Please kick off a CI.

[mhdawson]

CI run: https://ci.nodejs.org/job/node-test-pull-request/12897/

[yhwang]

one failure: test-http-pipeline-flood. It's a flaky test case.

[addaleax]

Landed in d161625

[MylesBorins]

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

[addaleax]

I’ve landed this as 4f21b66 in v8.x-staging because, as I understand it, it applies there as well – let me know if that was a mistake.