[backport-v8.x] http: add rawPacket in err of clientError event#18370
Closed
XadillaX wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
[backport-v8.x] http: add rawPacket in err of clientError event#18370XadillaX wants to merge 1 commit intonodejs:v8.x-stagingfrom
clientError event#18370XadillaX wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
The `rawPacket` is the current buffer that just parsed. Adding this buffer to the error object of `clientError` event is to make it possible that developers can log the broken packet. PR-URL: nodejs#17672 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
approved these changes
Jan 31, 2018
Contributor
Author
XadillaX
added a commit
that referenced
this pull request
Feb 8, 2018
The `rawPacket` is the current buffer that just parsed. Adding this buffer to the error object of `clientError` event is to make it possible that developers can log the broken packet. PR-URL: #18370 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
Author
|
landed on a71c7bb |
gibfahn
pushed a commit
that referenced
this pull request
Feb 8, 2018
The `rawPacket` is the current buffer that just parsed. Adding this buffer to the error object of `clientError` event is to make it possible that developers can log the broken packet. PR-URL: #17672 Backport-PR-URL: #18370 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
@XadillaX if you would like to help with backporting we (current backporters) would be extremely grateful, and I'd be happy to pair on the process and get you onboarded. However otherwise please don't land commits on staging branches, it makes it hard for the person doing the release to work out what is going on with the branch, and it's also a bit different to how we land things on master. Check out the commit message in 56401a4 for details. If I'm not getting round to landing it feel free to ping me in the issue. Relanded (with the right metadata) in 56401a4 |
Contributor
Author
|
@gibfahn Thx very much and sorry for what I have done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rawPacketis the current buffer that just parsed. Adding thisbuffer to the error object of
clientErrorevent is to make it possiblethat developers can log the broken packet.
PR-URL: #17672
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http