test: fix issues in inspector-helper#18293
test: fix issues in inspector-helper#18293apapirovski wants to merge 2 commits intonodejs:masterfrom
Conversation
apapirovski
added
the
fast-track
|
I think |
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Thanks for the quick fix on this, apologies for the noise.
|
@apapirovski it seems I messed up a sync to an older commit... I can PR the fix or we can revert for now as well. |
guybedford
dismissed
their stale review
I'm going to rather PR the fix with the test cases as well
|
@guybedford I should have a fix shortly. I'll include in this PR. |
apapirovski
changed the title
|
#18295 should cover the test cases here too. |
|
Will land this when CI is done since it has approvals. |
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Test case fix looks good to me, pending CI checks.
|
Seems like the Windows tests have unstable here. If you think that could have been introduced by this I'd be open to a revert. |
|
@guybedford I'm very certain those have been unstable for a while. I think we can land this. |
|
👍 sounds good to me. |
|
Landing... |
|
Landed in a3555d0 |
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
PR-URL: #18293 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
|
Should this be backported to |
PR-URL: nodejs#18293 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
6 participants
Fixes linting issues introduced in #18194
This needs to be fast-tracked.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test