stream: readable stream should not push undefined in non-objectMode#18244
Closed
MoonBall wants to merge 2 commits intonodejs:masterfrom
Closed
stream: readable stream should not push undefined in non-objectMode#18244MoonBall wants to merge 2 commits intonodejs:masterfrom
MoonBall wants to merge 2 commits intonodejs:masterfrom
Conversation
4 tasks
Member
|
Why do we need it? I'm not understanding the reasoning behind this. |
Member
Author
|
Current Node.js allows we to push |
Member
|
@MoonBall It would be helpful if you could explain why you think that that should not be allowed? |
Member
Author
|
There is no obvious reason. just feeling. |
Member
Author
|
@addaleax If we allow it, I can add a test case and a comment to explain the reason. |
Member
Author
ba704a3 to
a186f78
Compare
Member
Author
Member
|
Thanks for the investigation! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

From the doc:

But current Node.js allows we to push
undefinedwhen stream is in non-object mode.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
stream