benchmark: fix timeout bug in write-stream-throughput#17958
Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
Closed
benchmark: fix timeout bug in write-stream-throughput#17958apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
benchmark
jasnell
approved these changes
Jan 3, 2018
joyeecheung
approved these changes
Jan 3, 2018
cjihrig
approved these changes
Jan 3, 2018
apapirovski
added
the
author ready
lpinca
approved these changes
Jan 3, 2018
4 tasks
BridgeAR
approved these changes
Jan 4, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 5, 2018
PR-URL: nodejs#17958 Fixes: nodejs#17901 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in b43a496 |
Merged
TimothyGu
removed
the
author ready
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's possible for this benchmark to call
bench.end()beforebench.start(). Fix this to resolve some occasional CI flakiness.Fixes: #17901
CI: https://ci.nodejs.org/job/node-test-pull-request/12388/
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1600/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark