test: use countdown in test file#17874
Closed
sreepurnajasti wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
starkwang
approved these changes
Dec 27, 2017
Contributor
There was a problem hiding this comment.
It is better to add a mustCall for these two lines. For example:
new Countdown(total, common.mustCall(() => server.close()));
sreepurnajasti
force-pushed
the
pipeline
branch
from
c812e06 to
caa9d25
Compare
Member
|
If this commit is landed as it is, it will close the referenced issue (which I don't think is correct). |
jasnell
approved these changes
Dec 27, 2017
apapirovski
approved these changes
Dec 27, 2017
Contributor
There was a problem hiding this comment.
Could you update this const to be camelCase please?
Contributor
There was a problem hiding this comment.
I could be wrong but I don't think we strictly need two separate countdowns in this test? We could just use the responseCountdown and have the server.close() be inside it.
addaleax
approved these changes
Dec 27, 2017
gireeshpunathil
approved these changes
Dec 27, 2017
lpinca
approved these changes
Dec 27, 2017
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
LGTM with @apapirovski's comments addressed.
sreepurnajasti
force-pushed
the
pipeline
branch
from
caa9d25 to
7109991
Compare
Member
starkwang
added
the
author ready
starkwang
pushed a commit
that referenced
this pull request
Dec 30, 2017
Fixes: #17169 PR-URL: #17874 Fixes: #17169 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
|
Landed in 166a2ce. Thanks for your contribution! 🥇 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
Fixes: #17169 PR-URL: #17874 Fixes: #17169 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Fixes: #17169 PR-URL: #17874 Fixes: #17169 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Fixes: #17169 PR-URL: #17874 Fixes: #17169 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
TimothyGu
removed
the
author ready
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
Fixes: #17169 PR-URL: #17874 Fixes: #17169 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #17169
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)