test: refactor test-net-connect-buffer#17710
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
- Use arrow functions, `common.mustCall()` - Remove redundant `console.log()`s/turn them into assertions - Use `common.expectsError()`
addaleax
added
net
BridgeAR
approved these changes
Dec 16, 2017
Member
|
It feels weird that |
Member
Author
Member
|
Actually null is still special also in the binary case. You have to .push(null) on a Readable to terminate. |
Member
Author
|
Right … just seems odd since we also do the same type checks for |
lpinca
approved these changes
Dec 16, 2017
| socket.connect(this.address().port, common.mustCall(() => connected = true)); | ||
|
|
||
| assert.strictEqual(socket.connecting, true); | ||
| assert.strictEqual('opening', socket.readyState); |
Member
There was a problem hiding this comment.
Nit: now that you are here, can you please swap the arguments? There are more below.
lpinca
reviewed
Dec 16, 2017
| const tcp = net.Server(common.mustCall((s) => { | ||
| tcp.close(); | ||
|
|
||
| console.log('tcp server connection'); |
Member
There was a problem hiding this comment.
I would also remove the remaining console.log(), they don't seem to be very useful.
cjihrig
approved these changes
Dec 18, 2017
Member
|
@addaleax that's an oddity of streams backward compatibility. I'm ok in changing that if you want to fire a separate PR. |
jasnell
approved these changes
Dec 18, 2017
maclover7
approved these changes
Dec 21, 2017
Contributor
Contributor
|
Landing... |
Contributor
|
Landed in 7352bf2 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
- Use arrow functions, `common.mustCall()` - Remove redundant `console.log()`s/turn them into assertions - Use `common.expectsError()` PR-URL: #17710 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
- Use arrow functions, `common.mustCall()` - Remove redundant `console.log()`s/turn them into assertions - Use `common.expectsError()` PR-URL: #17710 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
- Use arrow functions, `common.mustCall()` - Remove redundant `console.log()`s/turn them into assertions - Use `common.expectsError()` PR-URL: #17710 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Merged
Contributor
|
test doesn't pass on 6.x or 8.x (commit lands on both). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.mustCall()console.log()s/turn them into assertionscommon.expectsError()Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test/net