added few more examples to fs.access. Fixes #17508

[mfaheemakhtar]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[Trott]

Hi, @mfaheemakhtar! Welcome and thanks for the pull request!

The text explanations have a number of very small issues but rather than enumerate them, I'm wondering if any of the explanatory text you added is necessary. I wonder if it all might be better as code comments in the examples you provide. For example, perhaps the first code sample could go from this:

fs.access('./package.json', fs.constants.F_OK, (err) => {
  console.log(err ? 'No package.json file!' : 'package.json exists!');
});

...to this:

// Check if `package.json` exists in the current directory.
fs.access('./package.json', fs.constants.F_OK, (err) => {
  console.log(err ? 'No package.json file!' : 'package.json exists!');
});

With the comment there, the two preceding sentences aren't needed anymore. The code is instead explained in the comments.

What do you think?

[mfaheemakhtar]

Hi @Trott , great idea! I'll improve the pull request.

Thanks for the suggestion.

UPDATE: I've made few changes. I would love to hear your feedback.

[Trott]

I think we can remove this sentence too. If you do wish to keep it, please change explains to explain and surround fs.constants with `.

[mfaheemakhtar]

Sure. I've removed the text. Any more feedback?

[BridgeAR]

Just a couple of smaller issues, but in general LGTM

[BridgeAR]

Line length > 80

[BridgeAR]

Whitespace after the if in if(.

[BridgeAR]

This example is pretty redundant as the only difference is checking for the error code. It should be obvious from the example above what to do.

[mfaheemakhtar]

Thank you, @BridgeAR. I appreciate your feedback.

[BridgeAR]

Since this is all about examples, we could actually use a single JS block that includes all the different examples. But that might just be my personal preference.

[BridgeAR]

@tabulatedreams thanks again for your PR. Great that you are helping out! Just some hints about how to make things easier, I recommend to run make lint. In this case you actually only have to run the documentation part (you find all the different options in the Makefile) but in general it is good to test everything.
Besides that, you might want to have another look at the commit guidelines and add the subsystem to your commit message. But that is not so important and can be done while landing as well.

[jasnell]

Please avoid using informal pronouns like "we" in the docs

[Trott]

...so maybe Check if package.json file can be read or something similar to that...

[mfaheemakhtar]

Thanks @jasnell and @Trott, I'm learning a lot of things. I'll keep these things in my mind.

[joyeecheung]

Ping @mfaheemakhtar, can you address the reviews and update this PR? Also looks like it needs a rebase. Thanks!

[mfaheemakhtar]

Sorry @joyeecheung, I had completely forgotten about this. Unfortunately, I am very busy nowadays and can't review and/or update PR. You can consider this PR as outdated and can be rejected/deleted.

Thank you. :)

[joyeecheung]

@mfaheemakhtar Sorry to hear that. I'll close this one out at the moment but if anyone in this thread wants to pursue this feel free to reopen or submit another PR.