Add tests into internal/crypto/random.js to improve coverage

[Leko]

I added these test case:

• Call randomBytes with cb is not a function
• Call randomFill with cb is not a function

Current coverage is here: https://coverage.nodejs.org/coverage-06e1b0386196f8f8/root/internal/crypto/random.js.html

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test

[apapirovski]

This seems fine but you could make it even better by using something similar to line 510. That is, having a forEach that iterates over several different types and makes sure that none of them are accepted for the callback param.

The current version makes sure that null isn't accepted but if someone accidentally changed the function to have a falsey check instead of typeof then it wouldn't catch that.

[Leko]

@apapirovski Thank you for review.

using something similar to line 510

I think it would be nice.
I updated test case. Please check it again.

[apapirovski]

Could this also be put inside the forEach loop? Or have a new forEach loop around it? Then we're good to go. :)

[Leko]

I moved it to inside the new forEach loop to omit undefined in test case.

function randomBytes(size, cb) {
  assertSize(size);
  Iif (cb !== undefined && typeof cb !== 'function') // <- undefined is omitted
    throw new errors.TypeError('ERR_INVALID_CALLBACK');

[apapirovski]

CI: https://ci.nodejs.org/job/node-test-pull-request/12051/

[apapirovski]

Landed in 7a055f1