test: use countdown in http-agent test

[fedekau]

Hi, this is my first PR to node!

I started by tackling one of the tests listed in #17169, in particular the test/parallel/test-http-agent.js test. Hopefully everything looks good to you, otherwise let me know what can be improved 😄

Checklist

• make -j4 test
• make lint
• commit message follows commit guidelines

[sreepurnajasti]

Limit of countdown can be outCount*inCount instead of 1.

[sreepurnajasti]

Can replace this whole if block with countdown.dec();

[sreepurnajasti]

Can remove responseCount variable.

[sreepurnajasti]

Thanks for contribution!!! Please, do use make lint/vcbuild lint before pr.

[fedekau]

@sreepurnajasti Thanks for the comments, I am pretty sure that I did run make lint, maybe I missed something 🤔 . I will run it again.

Do you think this would be ok ?

...
  const countdown = new Countdown(
    outCount * inCount,
    common.mustCall(() => server.close())
  );
  let onRequest = common.mustNotCall(); // Temporary
  const p = new Promise((resolve) => {
    onRequest = common.mustCall((res) => {
      if (countdown.dec() === 0) {
        resolve();
      }

      if (!shouldFail)
        res.resume();
    }, outCount * inCount);
  });
...

[apapirovski]

That should work. You can also run make -j4 test to make sure the test runs as expected. Or to run a single test, run tools/test.py --mode=release parallel/test-http-agent.

[fedekau]

Thanks @apapirovski, I have already run all tests and linter 😄 after amending the last commit

[sreepurnajasti]

@fedekau LGTM. Thanks!!

[apapirovski]

CI: https://ci.nodejs.org/job/node-test-pull-request/11991/

[fedekau]

@apapirovski Do you think that this failure is related to my change? To me seems like it is not, or is it? 🤔

[apapirovski]

@fedekau Completely unrelated, this PR is all good :)

[apapirovski]

Landed in f373a1d

Thanks for the contribution @fedekau! Congrats on becoming a Contributor! 🎉

[fedekau]

Thanks @apapirovski and @sreepurnajasti I hope this is the first of many PRs 💪