Closed
Conversation
maclover7
approved these changes
Dec 7, 2017
COLLABORATOR_GUIDE.md
Outdated
Contributor
There was a problem hiding this comment.
Shouldn't it be collaborators instead of Collaborators ? Its not the first word in a new line but part of the line right ?
Contributor
There was a problem hiding this comment.
Collaborator is a title and it should be capitalized.
Member
There was a problem hiding this comment.
Should we be linting for capitalizing Collaborator(s) then?
Member
Author
There was a problem hiding this comment.
Shouldn't it be
collaboratorsinstead ofCollaborators?
A case could be made for lower case or capitalizing. While I would prefer lower case myself, I am far more concerned with consistency. Since we capitalize it multiple times elsewhere in this and other documents, capitalizing it here normalizes things without a lot of needless churn.
README.md
Outdated
Contributor
There was a problem hiding this comment.
excluding Nightlies sounds more correct than but not Nightlies
Contributor
There was a problem hiding this comment.
"but not Nightlies" sounds better to me because the two preceding items do not include (or in any way reference) Nightlies so "excluding" doesn't make sense.
apapirovski
approved these changes
Dec 7, 2017
richardlau
reviewed
Dec 7, 2017
README.md
Outdated
Member
There was a problem hiding this comment.
Maybe remove the parentheses as well?
Member
Author
There was a problem hiding this comment.
@richardlau Yes, that's a good suggestion. Done!
* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators"
Use consistent typography and other minor changes to Verifying Binaries section.
Make text for Console constructor more precise.
Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md.
Member
Author
richardlau
approved these changes
Dec 7, 2017
lpinca
approved these changes
Dec 8, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 8, 2017
* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators" PR-URL: nodejs#17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 8, 2017
Use consistent typography and other minor changes to Verifying Binaries section. PR-URL: nodejs#17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 8, 2017
Make text for Console constructor more precise. PR-URL: nodejs#17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 8, 2017
Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md. PR-URL: nodejs#17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators" PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Use consistent typography and other minor changes to Verifying Binaries section. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Make text for Console constructor more precise. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators" PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Use consistent typography and other minor changes to Verifying Binaries section. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Make text for Console constructor more precise. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Member
|
Backported 5b4a5c8 and c3a9970 to v6.x. |
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators" PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Use consistent typography and other minor changes to Verifying Binaries section. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Make text for Console constructor more precise. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators" PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Make text for Console constructor more precise. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
* convert run-on sentence to a bulleted list * standardize capitalization in "Collaborators" PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Use consistent typography and other minor changes to Verifying Binaries section. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Make text for Console constructor more precise. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Rewrite and edit somewhat confusing paragraph about inodes and AIX in fs.md. PR-URL: #17519 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc