doc: remove unused link reference in child_process.md#17510
Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
Closed
doc: remove unused link reference in child_process.md#17510apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
child_process
2 tasks
Contributor
Author
Trott
approved these changes
Dec 7, 2017
maclover7
added
fast-track
Member
|
Absolutely 👍 to fast-tracking. |
apapirovski
changed the title
Contributor
Author
|
Will wait for the linter to finish then land this since it has 2 approvals now. |
Member
|
FYI (for @apapirovski but also for any other Collaborators because I don't think it's been widely publicized), for commits like this, you can choose the node-test-pull-request-lite task which will only run the linter and (because it's fast) the tests on linux-one. |
3 tasks
Contributor
Author
|
@Trott thanks. Good to know! |
Contributor
Author
|
Ok, we've been unbroken. Sorry about that. Landed in c892f6f |
apapirovski
added a commit
that referenced
this pull request
Dec 7, 2017
PR-URL: #17510 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17510 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17510 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17510 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17510 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaking the build. Would like to land almost immediately.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc