Refactor: Use common.expectsError in tests#17497
Closed
mithunsasidharan wants to merge 1 commit intonodejs:masterfrom
mithunsasidharan:common_5
Closed
Refactor: Use common.expectsError in tests#17497mithunsasidharan wants to merge 1 commit intonodejs:masterfrom mithunsasidharan:common_5
mithunsasidharan wants to merge 1 commit intonodejs:masterfrom
mithunsasidharan:common_5
Conversation
BridgeAR
approved these changes
Dec 6, 2017
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM but the commit message should start with the test subsystem.
Contributor
|
@mithunsasidharan FWIW, feel free to just open one big pull request if you're doing this for the rest of the tests. It will make it easier to land it and it's really not that hard to review, even if it's 100+ files. (Less to keep track of for backports too.) |
Contributor
|
Also, be prepared to backport all of these PRs to other release lines. |
maclover7
approved these changes
Dec 7, 2017
Contributor
lpinca
approved these changes
Dec 7, 2017
3 tasks
Contributor
|
Landed in acd4277 |
apapirovski
pushed a commit
that referenced
this pull request
Dec 8, 2017
PR-URL: #17497 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17497 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17497 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests to replace
assert.throws(fn, common.expectsError(err));withcommon.expectsError(fn, err);in following test files :Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test