test: Use mustCall in http test

[sreepurnajasti]

Refs: #17169

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[apapirovski]

Thanks for the contribution! Could you update to use common.mustCall instead since it only runs 1 iteration? Countdown is better for tests where n > 1.

(Also, the commit message will need to be updated and should be 50 chars or less.)

Thanks!

[apapirovski]

This test would be better if it used common.mustCall here instead of Countdown since it's just 1 iteration. The server.close() doesn't need to be conditional.

[maclover7]

LGTM once @apapirovski's comment is addressed

[sreepurnajasti]

@apapirovski Thanks for the feedback. Modified as per your suggestion. Please, have a look.

[apapirovski]

Thanks for making the changes. Some feedback below. Also, the process.on('exit'); block can also be removed since there's now a common.mustCall which verifies that the test runs long enough.

[apapirovski]

This line can be removed, we can safely call server.close() multiple times.

[sreepurnajasti]

Done!!

[apapirovski]

This can be removed.

[sreepurnajasti]

Thanks. Done!!

[apapirovski]

This should be common.mustCall which specifies COUNT as the 2nd argument, that way it will make sure that this function is called the right number of times. Something like:

common.mustCall((req, res) => {
  // test code here
}, COUNT);

[sreepurnajasti]

Thanks for explanation. Its Done.

[apapirovski]

CI: https://ci.nodejs.org/job/node-test-pull-request/11942/

[apapirovski]

Landed in f81bb7b

Thanks for the contribution @sreepurnajasti! 👍