doc: add info on post-publishing ARM6 builds#17455
doc: add info on post-publishing ARM6 builds#17455mhdawson wants to merge 1 commit intonodejs:masterfrom
Conversation
doc/releases.md
Outdated
There was a problem hiding this comment.
It would be good to specify the names of those sections in case the numbering gets changed later.
doc/releases.md
Outdated
There was a problem hiding this comment.
This seems like it should be part of the step above:
If you didn't wait for ARM builds in the previous step before promoting the release, you should re-run
tools/release.shafter the ARM builds have finished. That will move the ARM artifacts into the correct location. You will be prompted to re-sign SHASUMS256.txt.
There was a problem hiding this comment.
I feel it at least should not be after 17. Celebrate (which implies everything is done). As @gibfahn points out, it's already kind of mentioned in 12. Promote and Sign the Release Builds but maybe it's not prominent enough because we have frequently forgotten to promote them (e.g. nodejs/nodejs.org#1382).
Also is there any particular reason to include the 6 and not just say ARM?
There was a problem hiding this comment.
It is only the ARMv6 builds that are really slow.
|
@gibfahn updated to merge into that step. |
doc/releases.md
Outdated
There was a problem hiding this comment.
Maybe make it:
[`iojs-release-arm6-only`](https://ci-release.nodejs.org/job/iojs+release-arm6-only/)
|
cc/ @nodejs/release |
doc/releases.md
Outdated
There was a problem hiding this comment.
Nit - Since the other sentences only use a single whitespace after a sentence, I would suggest to do the same here?
|
Will do, its hard to overcome many years at school (in the past) where 2 spaces was the only way :) |
|
CI looks good landing. |
ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case.
|
Landed as 4e65f9d |
ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case. PR-URL: #17455 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case. PR-URL: #17455 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case. PR-URL: #17455 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case. PR-URL: #17455 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ARM6 takes longer, more often fails builds than other platforms. Add instructions for how to recover in this case. PR-URL: #17455 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
7 participants
ARM6 takes longer, more often fails builds than other
platforms. Add instructions for how to recover in this
case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc