tools: host remark-preset-lint-node in-tree#17441
tools: host remark-preset-lint-node in-tree#17441maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-mv-preset
Conversation
|
Now that I'm seeing the change set, it makes me want to ask: What's the advantage of doing it this way? |
|
@Trott main advantages are that there's no need to publish versions on npm or worry about staying up to date with a separate repo -- basically the same deal we have with the docs generator tool. |
|
@nodejs/collaborators thoughts? |
|
Initially, it was an independent private package when I added so we didn't need to worry about the version of the Also, it's totally fine to transfer the remark-preset-lint-node repository under @nodejs org if we want :) // Sorry for my late response! |
|
@nodejs/collaborators any thoughts? With this the project markdown lint rules will live inside |
|
Landed in a9e422e |
Moved from https://github.com/watilde/remark-preset-lint-node. PR-URL: nodejs#17441 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Moved from https://github.com/watilde/remark-preset-lint-node. PR-URL: #17441 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Moved from https://github.com/watilde/remark-preset-lint-node. PR-URL: #17441 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Moved from https://github.com/watilde/remark-preset-lint-node. PR-URL: #17441 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
This doesn't land cleanly on LTS. please feel free to backport. Marked as don't land for now |
8 participants
Moved from https://github.com/watilde/remark-preset-lint-node. The source for this preset will now live in the nodejs/node repository.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools