vm: never abort on caught syntax error#17394
Conversation
nodejs-github-bot
added
c++
lib/vm.js
Outdated
There was a problem hiding this comment.
@nodejs/v8 Is this a bug in V8?
There was a problem hiding this comment.
Yeah a ReThrow is not actually a new throw. It just "re-activates" the exception.
There was a problem hiding this comment.
@hashseed Does that mean one could get the right behavior by exiting the TryCatch scope, then using isolate->ThrowException()?
There was a problem hiding this comment.
Yeah. Though the message you get with this kind of "rethrow" will show the stack trace of the new throw location.
addaleax
force-pushed
the
vm-no-abort
branch
from
4e7ba98 to
250ab47
Compare
addaleax
added
vm
|
Hm – looks like message tests fail, because the throw in JS makes us drop the filename from the output… going to need to look into this a bit more I guess |
addaleax
force-pushed
the
vm-no-abort
branch
from
250ab47 to
62233c9
Compare
|
Okay, I think I fixed it with some … cleverness. I’d appreciate it if @bnoordhuis could take a look? |
lib/vm.js
Outdated
There was a problem hiding this comment.
Any idea for how to avoid this? Or: Is this even actually a bad thing?
There was a problem hiding this comment.
Why would it be a bad thing?
There was a problem hiding this comment.
I am not sure - it seems like something that people might find out, start to use, and be unhappy when they find out we changed/removed/etc. it
There was a problem hiding this comment.
I'm not sure what "it" refers to. The line in the (decorated) stack trace? What info could they glean from that?
There was a problem hiding this comment.
No, sorry, I should have been clearer - I was talking about the node-do-not-add-exception-line magic string and its effect of not appending the filename + arrow string in that case
There was a problem hiding this comment.
Hah, okay. I read your question as "is it a bad thing for the throw to show up." I wouldn't say so, and yes, I'd say it's only a matter of time before people find out about the magic comment. :-)
If you want to exclude stack frames, you can filter based on the script id. Probably overkill for this, though.
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway.
Keep track of C++ `TryCatch` state to avoid aborting when an exception is thrown inside one, and re-throw in JS to make sure the exception is being picked up a second time by a second uncaught exception handler, if necessary. Add a bit of a hack to `AppendExceptionLine` to avoid overriding the line responsible for re-throwing the exception. Fixes: nodejs#13258
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: #17394 Reviewed-By: James M Snell <[email protected]>
Keep track of C++ `TryCatch` state to avoid aborting when an exception is thrown inside one, and re-throw in JS to make sure the exception is being picked up a second time by a second uncaught exception handler, if necessary. Add a bit of a hack to `AppendExceptionLine` to avoid overriding the line responsible for re-throwing the exception. PR-URL: #17394 Fixes: #13258 Reviewed-By: James M Snell <[email protected]>
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
Refs: nodejs#17394
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
PR-URL: #17491
Refs: #17394
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
|
Should this be backported to |
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
PR-URL: #17491
Refs: #17394
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
|
Got it to land !!! |
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: #17394 Reviewed-By: James M Snell <[email protected]>
Keep track of C++ `TryCatch` state to avoid aborting when an exception is thrown inside one, and re-throw in JS to make sure the exception is being picked up a second time by a second uncaught exception handler, if necessary. Add a bit of a hack to `AppendExceptionLine` to avoid overriding the line responsible for re-throwing the exception. PR-URL: #17394 Fixes: #13258 Reviewed-By: James M Snell <[email protected]>
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
PR-URL: #17491
Refs: #17394
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
|
does this make sense for lts? edit: if backported it should come with #17491 |
|
ping re: backport |
|
one more backport ping should come with #17491 |
7 participants
Fixes: #13258
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
vm