Closed
Conversation
addaleax
approved these changes
Nov 27, 2017
addaleax
added
fast-track
TimothyGu
approved these changes
Nov 27, 2017
maclover7
approved these changes
Nov 27, 2017
cjihrig
approved these changes
Nov 27, 2017
danbev
approved these changes
Nov 28, 2017
doc/guides/writing-tests.md
Outdated
Contributor
There was a problem hiding this comment.
LGTM, could you also pass the env to the AtExit function:
node::AtExit(env, at_exit_callback);Without this AtExit will use the thread local environment which will be different and cause a segment fault. I'll take a closer look into the exact cause of this, or let me know if you'd like to dig into it further.
cctest guide example wasn't working because of a few typos.
mmarchini
force-pushed
the
fix-cctest-doc
branch
from
878c380 to
4bb9e53
Compare
Contributor
Author
|
@danbev |
aqrln
approved these changes
Nov 28, 2017
Contributor
|
Landing... |
maclover7
pushed a commit
that referenced
this pull request
Nov 30, 2017
cctest guide example wasn't working because of a few typos. PR-URL: #17355 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Contributor
|
Thank you for your contribution, landed in c9d1704. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
cctest guide example wasn't working because of a few typos. PR-URL: #17355 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
cctest guide example wasn't working because of a few typos. PR-URL: #17355 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
cctest guide example wasn't working because of a few typos. PR-URL: #17355 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
cctest guide example wasn't working because of a few typos. PR-URL: #17355 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cctest guide example wasn't working because of a few typos.
Checklist
Affected core subsystem(s)
doc