build: add a make help option for common targets#17323
Conversation
nodejs-github-bot
added
the
build
maclover7
left a comment
maclover7
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM
Makefile
Outdated
There was a problem hiding this comment.
build docs --> builds docs?
There was a problem hiding this comment.
LGTM but cc @joyeecheung, this PR overlaps to some extent with #16975.
(edit: nevermind, just saw this PR is in response to that PR.)
Makefile
Outdated
There was a problem hiding this comment.
Can you add a line break to keep it < 81 columns?
Yep, this is meant to complement that PR, so would definitely appreciate a review from @joyeecheung ! |
|
Might be too much of a change, but just for info, the alacritty Makefile I got the idea from sets |
|
Doesn't |
|
@richardlau good point, yes it does, should have rechecked after moving it up to the top. I've moved it down to below. TBH I think having it be the default makes sense, but I'd rather get this landed so people can start using it, and have that discussion afterwards. |
Makefile
Outdated
There was a problem hiding this comment.
should this be removed or just moved down to the next line?
There was a problem hiding this comment.
Yes..why are we removing this?
There was a problem hiding this comment.
My bad, I made it an inline comment, then decided the help was getting too long and removed it again. Fixed.
|
Is the |
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM minus a question about removing coverage-clean comments
Makefile
Outdated
There was a problem hiding this comment.
Yes..why are we removing this?
gibfahn
force-pushed
the
make-help
branch
2 times, most recently
from
fba663c to
ab388f1
Compare
Added a line to explain. |
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
New target help should be phony but otherwise LGTM.
Done |
|
ping @gibfahn — does this need anything else to land? |
PR-URL: nodejs#17323 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #17323 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #17323 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #17323 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
12 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build
The Makefile has quite a large number of targets, so I only added the ones that I thought people would most need to know about.
Output: