test: use common.hasIntl instead of typeof Intl in Intl v8BreakIterator test#17311
Closed
AquiTCD wants to merge 1 commit intonodejs:masterfrom
AquiTCD:replace-to-common-from-typeof
Closed
test: use common.hasIntl instead of typeof Intl in Intl v8BreakIterator test#17311AquiTCD wants to merge 1 commit intonodejs:masterfrom AquiTCD:replace-to-common-from-typeof
AquiTCD wants to merge 1 commit intonodejs:masterfrom
AquiTCD:replace-to-common-from-typeof
Conversation
Member
There was a problem hiding this comment.
common.hasIntl returns boolean, it does not match 'undefined'.
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing, I fixed it to expect boolean.
joyeecheung
approved these changes
Nov 26, 2017
targos
approved these changes
Nov 26, 2017
Member
lpinca
approved these changes
Nov 26, 2017
gireeshpunathil
added
the
code-and-learn
gireeshpunathil
approved these changes
Nov 26, 2017
mscdex
added
i18n-api
maclover7
approved these changes
Nov 26, 2017
jasnell
approved these changes
Nov 26, 2017
jasnell
pushed a commit
that referenced
this pull request
Nov 26, 2017
PR-URL: #17311 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 6a99224. Thank you and congrats on your PR to core! |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17311 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17311 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Member
|
@bnoordhuis I see you made the change this commit undoes in 668ad44, is there a reason you didn't keep -if (!common.hasIntl || Intl.v8BreakIterator === undefined)
+if (typeof Intl === 'undefined')Just checking there isn't a problem with it here. (This commit depends on #15238, so shouldn't be backported anyway) |
Member
|
I changed it because the test tests properties from the Intl object and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a part of Nodefest's Code and Learn nodejs/code-and-learn#72
I replace
typeof Intltocommon.hasIntlintest/parallel/test-intl-v8BreakIterator.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)