Closed
Conversation
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: nodejs#14901 Fixes: nodejs/node-v8#26
nodejs-github-bot
added
the
build
Member
Author
|
I already tested this on my v8-6.3 branch: https://ci.nodejs.org/job/node-test-commit-v8-linux/1071/ |
richardlau
reviewed
Nov 23, 2017
| --no-presubmit \ | ||
| --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ | ||
| $(TAP_V8) | ||
| git clean -fdxq -- deps/v8 |
Member
There was a problem hiding this comment.
Can we assume the presence of git, i.e. is this target valid for running from the source tarball?
Member
Author
There was a problem hiding this comment.
This target depends on the v8 target, which executes make-v8.sh, which already assumes the presence of git.
Contributor
There was a problem hiding this comment.
But maybe replace x with X?
If I'm understanding git's logic, it'll use node's .git not deps/v8/.git
Member
Author
There was a problem hiding this comment.
deps/v8/.git is removed in make-v8.sh during cleanup:
Line 16 in 088bba3
Contributor
There was a problem hiding this comment.
So definatly -X (it will remove explicitly ignored files, while keeping newly added files)
richardlau
approved these changes
Nov 23, 2017
Member
Author
|
Test failure is unrelated. See #17270 |
gibfahn
approved these changes
Nov 23, 2017
Member
|
I want to propose reverting #14901 for now. |
Contributor
|
I see no harm in this change even after 088bba3. |
refack
approved these changes
Nov 23, 2017
Contributor
|
landed in 6c47033 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in 1 to use ignored
files while generating
node-debug-support.cc.Fixes: nodejs/node-v8#26
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @bnoordhuis @mmarchini