Conversation
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
I think this should have backticks around nodejs/node, to follow the rest of the doc.
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Split to 80 char line lengths while you're here?
There was a problem hiding this comment.
done. while I was there, I split the entire document to 80 char line lengths and put the links at the bottom.
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Can you mention the test-v8 target in the Makefile (and possibly make-v8.sh)? It takes quite long to actually run locally but mentioning it here at least leaves a pointer about how to update the CI.
There was a problem hiding this comment.
I can. Do you have a suggestion for the wording?
There was a problem hiding this comment.
Maybe Note: The CI uses the `test-v8` target in the `Makefile`, which uses `tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to run V8 tests.
- Mention the now existing Node.js canary branch. - Clearer steps for backporting commits. - Mention that `update-v8` can be used to simplify backports and updates. - Remove section about proposal for floating patches: embedder string has been implemented. - Wrap lines at 80 characters.
- Mention the now existing Node.js canary branch. - Clearer steps for backporting commits. - Mention that `update-v8` can be used to simplify backports and updates. - Remove section about proposal for floating patches: embedder string has been implemented. - Wrap lines at 80 characters. PR-URL: #17260 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in 1b9915f |
- Mention the now existing Node.js canary branch. - Clearer steps for backporting commits. - Mention that `update-v8` can be used to simplify backports and updates. - Remove section about proposal for floating patches: embedder string has been implemented. - Wrap lines at 80 characters. PR-URL: #17260 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
- Mention the now existing Node.js canary branch. - Clearer steps for backporting commits. - Mention that `update-v8` can be used to simplify backports and updates. - Remove section about proposal for floating patches: embedder string has been implemented. - Wrap lines at 80 characters. PR-URL: #17260 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Don't think this is worth backporting, but if anyone disagrees feel free to raise backports for v6.x and v8.x. |
6 participants
update-v8can be used to simplify backports andupdates.
has been implemented.