test: add crashOnUnhandledRejection#17237
Closed
DanielLin9406 wants to merge 1 commit intonodejs:masterfrom
DanielLin9406:nodefork
Closed
test: add crashOnUnhandledRejection#17237DanielLin9406 wants to merge 1 commit intonodejs:masterfrom DanielLin9406:nodefork
DanielLin9406 wants to merge 1 commit intonodejs:masterfrom
DanielLin9406:nodefork
Conversation
DanielLin9406
changed the title
Member
|
@DanielLin9406 your email id is not associated with this commit (github will fail to highlight you as a contributor). Please update |
gireeshpunathil
approved these changes
Nov 22, 2017
MylesBorins
previously requested changes
Nov 22, 2017
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
Can you please squash your two commits and update the commit message to
test: add crashonUnhandledRejection
Contributor
There was a problem hiding this comment.
this line should not be removed
gireeshpunathil
added
the
code-and-learn
jasnell
approved these changes
Nov 22, 2017
Member
jasnell
pushed a commit
that referenced
this pull request
Nov 22, 2017
PR-URL: #17237 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 3f19ecd. thank you! and congrats on your PR to core! |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17237 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17237 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17237 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17237 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)