test: use common.crashOnUnhandledRejection to test-promise.js#17229
Closed
kurthsu wants to merge 1 commit intonodejs:masterfrom
kurthsu:update-test-promise
Closed
test: use common.crashOnUnhandledRejection to test-promise.js#17229kurthsu wants to merge 1 commit intonodejs:masterfrom kurthsu:update-test-promise
kurthsu wants to merge 1 commit intonodejs:masterfrom
kurthsu:update-test-promise
Conversation
nodejs-github-bot
added
async_hooks
MylesBorins
previously requested changes
Nov 22, 2017
| const common = require('../common'); | ||
| common.crashOnUnhandledRejection(); | ||
|
|
||
| // This test ensures that the promise handling resolution correctly |
Contributor
There was a problem hiding this comment.
I don't think this comment is necessary, can you please remove it
gireeshpunathil
added
the
code-and-learn
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| common.crashOnUnhandledRejection(); |
Contributor
There was a problem hiding this comment.
Can you please move this after all the require statements
Member
Member
|
Fixing the nits on landing |
jasnell
approved these changes
Nov 22, 2017
jasnell
pushed a commit
that referenced
this pull request
Nov 23, 2017
PR-URL: #17229 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 01dc6d2! Thank you and congrats on the PR to core! |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17229 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17229 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17229 Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17229 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)