Closed
Conversation
nodejs-github-bot
added
the
v8 engine
Contributor
Author
Contributor
Author
|
@nodejs/v8 it looks like this patch is breaking some stuff on master, specifically 😢 |
Member
|
I wonder how that can happen, considering how upstream works fine. |
Member
|
Master is already broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/1072/ |
Contributor
Author
|
Odd, when did that happen? Was it a aptch we floated without running CI?
…On Nov 23, 2017 5:19 PM, "Michaël Zasso" ***@***.***> wrote:
Master is already broken: https://ci.nodejs.org/job/
node-test-commit-v8-linux/1072/
This patch is not related.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17206 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV446wyiPJ_jMzspc709q0kZlWpFOks5s5SqQgaJpZM4QmzcH>
.
|
Member
|
@MylesBorins yes. See #17270 |
Contributor
Author
|
As the single failure for this is a known failure do you think it makes sense for us to just land this? Can I please get some sign off on this @targos or @nodejs/v8 |
targos
approved these changes
Nov 26, 2017
Contributor
Author
|
landed in 04aab13 |
MylesBorins
added a commit
that referenced
this pull request
Nov 26, 2017
Refs: v8/v8@6.2.414.44...6.2.414.46 PR-URL: #17206 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
added a commit
that referenced
this pull request
Dec 12, 2017
Refs: v8/v8@6.2.414.44...6.2.414.46 PR-URL: #17206 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
added a commit
that referenced
this pull request
Dec 12, 2017
Refs: v8/v8@6.2.414.44...6.2.414.46 PR-URL: #17206 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
added a commit
that referenced
this pull request
Dec 12, 2017
Notable changes:
* async\_hooks:
- add trace events to async_hooks (Andreas Madsen)
#15538
- add provider types for net server (Andreas Madsen)
#17157
* console:
- console.debug can now be used outside of the inspector
(Benjamin Zaslavsky) #17033
* deps:
- upgrade libuv to 1.18.0 (cjihrig)
#17282
- patch V8 to 6.2.414.46 (Myles Borins)
#17206
* module:
- module.builtinModules will return a list of built in modules
(Jon Moss) #16386
* n-api:
- add helper for addons to get the event loop (Anna Henningsen)
#17109
* process:
- process.setUncaughtExceptionCaptureCallback can now be used to
customize behavior for `--abort-on-uncaught-exception`
(Anna Henningsen) #17159
- A signal handler is now able to receive the signal code that
triggered the handler. (Robert Rossmann)
#15606
* src:
- embedders can now use Node::CreatePlatform to create an instance of
NodePlatform (Cheng Zhao)
#16981
* stream:
- writable.writableHighWaterMark and readable.readableHighWaterMark
will return the values the stream object was instantiated with
(Calvin Metcalf) #12860
* **Added new collaborators**
* [maclover7](https://github.com/maclover7) Jon Moss
* [guybedford](https://github.com/guybedford) Guy Bedford
* [hashseed](https://github.com/hashseed) Yang Guo
PR-URL: Coming Soon
Merged
MylesBorins
added a commit
that referenced
this pull request
Dec 12, 2017
Notable changes:
* async\_hooks:
- add trace events to async_hooks (Andreas Madsen)
#15538
- add provider types for net server (Andreas Madsen)
#17157
* console:
- console.debug can now be used outside of the inspector
(Benjamin Zaslavsky) #17033
* deps:
- upgrade libuv to 1.18.0 (cjihrig)
#17282
- patch V8 to 6.2.414.46 (Myles Borins)
#17206
* module:
- module.builtinModules will return a list of built in modules
(Jon Moss) #16386
* n-api:
- add helper for addons to get the event loop (Anna Henningsen)
#17109
* process:
- process.setUncaughtExceptionCaptureCallback can now be used to
customize behavior for `--abort-on-uncaught-exception`
(Anna Henningsen) #17159
- A signal handler is now able to receive the signal code that
triggered the handler. (Robert Rossmann)
#15606
* src:
- embedders can now use Node::CreatePlatform to create an instance of
NodePlatform (Cheng Zhao)
#16981
* stream:
- writable.writableHighWaterMark and readable.readableHighWaterMark
will return the values the stream object was instantiated with
(Calvin Metcalf) #12860
* **Added new collaborators**
* [maclover7](https://github.com/maclover7) Jon Moss
* [guybedford](https://github.com/guybedford) Guy Bedford
* [hashseed](https://github.com/hashseed) Yang Guo
PR-URL: #17631
MylesBorins
added a commit
that referenced
this pull request
Dec 12, 2017
Notable changes:
* async\_hooks:
- add trace events to async_hooks (Andreas Madsen)
#15538
- add provider types for net server (Andreas Madsen)
#17157
* console:
- console.debug can now be used outside of the inspector
(Benjamin Zaslavsky) #17033
* deps:
- upgrade libuv to 1.18.0 (cjihrig)
#17282
- patch V8 to 6.2.414.46 (Myles Borins)
#17206
* module:
- module.builtinModules will return a list of built in modules
(Jon Moss) #16386
* n-api:
- add helper for addons to get the event loop (Anna Henningsen)
#17109
* process:
- process.setUncaughtExceptionCaptureCallback can now be used to
customize behavior for `--abort-on-uncaught-exception`
(Anna Henningsen) #17159
- A signal handler is now able to receive the signal code that
triggered the handler. (Robert Rossmann)
#15606
* src:
- embedders can now use Node::CreatePlatform to create an instance of
NodePlatform (Cheng Zhao)
#16981
* stream:
- writable.writableHighWaterMark and readable.readableHighWaterMark
will return the values the stream object was instantiated with
(Calvin Metcalf) #12860
* **Added new collaborators**
* [maclover7](https://github.com/maclover7) Jon Moss
* [guybedford](https://github.com/guybedford) Guy Bedford
* [hashseed](https://github.com/hashseed) Yang Guo
PR-URL: #17631
Justkant
reviewed
Dec 20, 2017
| the modified files will be rebuilt (not the target itself, which | ||
| might also cause unaffected dependencies to be rebuilt). An empty | ||
| list will be treated as if there are no additional targets to build. | ||
| (GN: group, GYP: none) target like 'blink_tests' or or even the |
| ### `mb analyze` | ||
|
|
||
| `mb analyze` is responsible for determining what targets are affected by | ||
| `mb analyze` is reponsible for determining what targets are affected by |
There was a problem hiding this comment.
which repo this typos should be reported?
Member
There was a problem hiding this comment.
In the V8 project: https://bugs.chromium.org/p/v8/issues/list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@6.2.414.44...6.2.414.46