Skip to content

test: remove unused variable#17187

Closed
gflandre wants to merge 1 commit intonodejs:masterfrom
gflandre:fix-unused-var
Closed

test: remove unused variable#17187
gflandre wants to merge 1 commit intonodejs:masterfrom
gflandre:fix-unused-var

Conversation

@gflandre
Copy link
Contributor

@gflandre gflandre commented Nov 21, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2017
@targos
Copy link
Member

targos commented Nov 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11577/

@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 21, 2017
jasnell
jasnell approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to wait the 48 hours to land. CI looks good

@aqrln aqrln added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2017
jasnell pushed a commit that referenced this pull request Nov 21, 2017
@gflandre @jasnell
test: remove unused variable
5bc7792 
PR-URL: #17187
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Landed in 5bc7792! Thank you and congrats on your first PR to core! :-)

@jasnell jasnell closed this Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@gflandre @MylesBorins
test: remove unused variable
2e31126 
PR-URL: #17187
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@gflandre @MylesBorins
test: remove unused variable
4eb1b58 
PR-URL: #17187
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@gflandre @gibfahn
test: remove unused variable
0b86469 
PR-URL: #17187
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gflandre @gibfahn
test: remove unused variable
9c6b845 
PR-URL: #17187
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+2 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@aqrln aqrln aqrln approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.